From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qn96v-0004cM-WC
	for qemu-devel@nongnu.org; Sat, 30 Jul 2011 08:57:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qn96u-00026S-Vh
	for qemu-devel@nongnu.org; Sat, 30 Jul 2011 08:57:45 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:44995)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qn96u-00026C-So
	for qemu-devel@nongnu.org; Sat, 30 Jul 2011 08:57:44 -0400
Received: by ywb3 with SMTP id 3so258475ywb.4
	for <qemu-devel@nongnu.org>; Sat, 30 Jul 2011 05:57:44 -0700 (PDT)
Message-ID: <4E33FFC6.7010807@codemonkey.ws>
Date: Sat, 30 Jul 2011 07:57:42 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1312018756.git.jan.kiszka@web.de>
	<328490ad2c7aeb3ebf2404264b36368ce06e8579.1312018756.git.jan.kiszka@web.de>
In-Reply-To: <328490ad2c7aeb3ebf2404264b36368ce06e8579.1312018756.git.jan.kiszka@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/15] sdl: Fix termination in -no-shutdown
 mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 07/30/2011 04:39 AM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Just like the monitor does, we need to clear no_shutdown before calling
> qemu_system_shutdown_request on quit requests. Otherwise, QEMU just
> stops the VM.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   ui/sdl.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/ui/sdl.c b/ui/sdl.c
> index 6dbc5cb..9efcda5 100644
> --- a/ui/sdl.c
> +++ b/ui/sdl.c
> @@ -672,8 +672,10 @@ static void sdl_refresh(DisplayState *ds)
>                   sdl_process_key(&ev->key);
>               break;
>           case SDL_QUIT:
> -            if (!no_quit)
> +            if (!no_quit) {
> +                no_shutdown = 0;
>                   qemu_system_shutdown_request();
> +            }
>               break;
>           case SDL_MOUSEMOTION:
>               if (gui_grab || kbd_mouse_is_absolute() ||