From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qnb1k-0002yW-8q
	for qemu-devel@nongnu.org; Sun, 31 Jul 2011 14:46:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qnb1j-000704-8G
	for qemu-devel@nongnu.org; Sun, 31 Jul 2011 14:46:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39722)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qnb1j-0006zu-1D
	for qemu-devel@nongnu.org; Sun, 31 Jul 2011 14:46:15 -0400
Message-ID: <4E35A2F1.7060807@redhat.com>
Date: Sun, 31 Jul 2011 21:46:09 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1312135082-31985-1-git-send-email-avi@redhat.com>
	<1312135082-31985-4-git-send-email-avi@redhat.com>
	<4E35A229.9020800@web.de>
In-Reply-To: <4E35A229.9020800@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives
 to the memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>

On 07/31/2011 09:42 PM, Jan Kiszka wrote:
> On 2011-07-31 19:57, Avi Kivity wrote:
> >  Convert all vga memory to the memory API.  Note we need to fall back to
> >  get_system_memory(), since the various buses don't pass the vga window
> >  as a memory region.
> >
> >  We no longer need to sync the dirty bitmap of the cirrus mapped memory
> >  banks, since the memory API takes care of that for us.
> >
> >  [jan: fix vga-pci logging]
>
> grub2 in graphical mode (likely via VBE) is still broken under kvm.

Sorry, I forgot about it.  Will take a look.

>   How
> did you try to address the flush-before-remap issue?
>

I haven't.  How does "unconditionally dirty the remapped slot" sound?

I think it isn't introduced by this patchset, yes?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.