From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qnb3o-0004eR-Js for qemu-devel@nongnu.org; Sun, 31 Jul 2011 14:48:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qnb3n-0007ab-KX for qemu-devel@nongnu.org; Sun, 31 Jul 2011 14:48:24 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:57363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qnb3n-0007aU-9q for qemu-devel@nongnu.org; Sun, 31 Jul 2011 14:48:23 -0400 Message-ID: <4E35A371.9080802@web.de> Date: Sun, 31 Jul 2011 20:48:17 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-4-git-send-email-avi@redhat.com> <4E35A229.9020800@web.de> <4E35A2F1.7060807@redhat.com> In-Reply-To: <4E35A2F1.7060807@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB43F7EFF047B9761312CC756" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB43F7EFF047B9761312CC756 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-07-31 20:46, Avi Kivity wrote: > On 07/31/2011 09:42 PM, Jan Kiszka wrote: >> On 2011-07-31 19:57, Avi Kivity wrote: >> > Convert all vga memory to the memory API. Note we need to fall >> back to >> > get_system_memory(), since the various buses don't pass the vga win= dow >> > as a memory region. >> > >> > We no longer need to sync the dirty bitmap of the cirrus mapped mem= ory >> > banks, since the memory API takes care of that for us. >> > >> > [jan: fix vga-pci logging] >> >> grub2 in graphical mode (likely via VBE) is still broken under kvm. >=20 > Sorry, I forgot about it. Will take a look. >=20 >> How >> did you try to address the flush-before-remap issue? >> >=20 > I haven't. How does "unconditionally dirty the remapped slot" sound? >=20 > I think it isn't introduced by this patchset, yes? The patch removes the explicit sync from the cirrus code. But the underlying issue is older of course. Jan --------------enigB43F7EFF047B9761312CC756 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk41o3UACgkQitSsb3rl5xTYiACfRCmg0hR5aFkzpDJBgdqPVFyK qxsAoKkUDkN8cnkfI/oCP5hFvbPMIgAx =3ZD3 -----END PGP SIGNATURE----- --------------enigB43F7EFF047B9761312CC756--