From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QngN5-0001iJ-Uw for qemu-devel@nongnu.org; Sun, 31 Jul 2011 20:28:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QngN4-0006Lm-Pi for qemu-devel@nongnu.org; Sun, 31 Jul 2011 20:28:39 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:63477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QngN4-0006Lf-KK for qemu-devel@nongnu.org; Sun, 31 Jul 2011 20:28:38 -0400 Received: by gwb19 with SMTP id 19so4059635gwb.4 for ; Sun, 31 Jul 2011 17:28:37 -0700 (PDT) Message-ID: <4E35F333.7050106@codemonkey.ws> Date: Sun, 31 Jul 2011 19:28:35 -0500 From: Anthony Liguori MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/15] sdl: Usability improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Stefano Stabellini On 07/30/2011 04:39 AM, Jan Kiszka wrote: > As SDL is my preferred way of working ad-hoc with guests, I had a closer > look at oddities and shortcomings that this GUI exposed, at least here > on Linux hosts. The result is a series of patches I've now finally > polished and completed. Highlights: > - fix termination in -no-shutdown mode > - fix various issues when switching to/from full screen mode > - polish mouse grabbing in full screen mode, under text console and > when in absolute mouse mode > - dynamically grab keyboard input in absolute mouse mode, enabling > e.g. ALT+TAB in the guest > - add zoom hot keys to make window scaling more attractive > - refactor some ugly functions > > Please review/merge. Reviewed-by: Anthony Liguori For the whole series. I'll merge tomorrow after some testing. At some point, I need to rebase my gtk backend... Regards, Anthony Liguori > > CC: Stefano Stabellini > > Jan Kiszka (15): > sdl: Fix termination in -no-shutdown mode > sdl: Do not make full screen mode resizable > sdl: Avoid redundant scaling deactivation > sdl: Properly mark modifier+u as hotkey > sdl: Fix full screen toggling from scaled mode > sdl: Restore scaling mode on return from full screen > sdl: Drop bogus gui_fullscreen_initial_grab > sdl: Initialize gui_fullscreen earlier during setup > sdl: Consistently avoid grabbing input for text consoles > sdl: Never release input while in full screen mode > sdl: Fix cursor handling when switching consoles in absolute mouse > mode > sdl: Dynamically grab input in absolute mouse mode > sdl: Add zoom hot keys > sdl: Factor out event handlers from sdl_refresh > sdl: Refactor sdl_send_mouse_event > > qemu-doc.texi | 8 + > ui/sdl.c | 547 ++++++++++++++++++++++++++++++++++++--------------------- > 2 files changed, 355 insertions(+), 200 deletions(-) >