From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QnldU-0001eb-9J for qemu-devel@nongnu.org; Mon, 01 Aug 2011 02:05:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QnldT-0001ro-Bk for qemu-devel@nongnu.org; Mon, 01 Aug 2011 02:05:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QnldT-0001rg-3P for qemu-devel@nongnu.org; Mon, 01 Aug 2011 02:05:55 -0400 Message-ID: <4E36423B.1080902@redhat.com> Date: Mon, 01 Aug 2011 09:05:47 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-10-git-send-email-avi@redhat.com> <4E35F128.2020309@twiddle.net> In-Reply-To: <4E35F128.2020309@twiddle.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/39] Integrate I/O memory regions into qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/01/2011 03:19 AM, Richard Henderson wrote: > On 07/31/2011 10:57 AM, Avi Kivity wrote: > > + system_io = qemu_malloc(sizeof(*system_io)); > > + memory_region_init(system_memory, "io", 65536); > > + set_system_io_map(system_io); > > Cut-paste error on that second line. > Well spotted; the cpu also saw this and the fix is in patch 10, which I forgot to squash into this. I'll post a squashed version. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.