From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qnsr4-00086F-SX for qemu-devel@nongnu.org; Mon, 01 Aug 2011 09:48:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qnsr0-0005Iv-Tq for qemu-devel@nongnu.org; Mon, 01 Aug 2011 09:48:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qnsr0-0005Ie-BN for qemu-devel@nongnu.org; Mon, 01 Aug 2011 09:48:22 -0400 Message-ID: <4E36AF54.9050709@redhat.com> Date: Mon, 01 Aug 2011 15:51:16 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1311914994-20482-1-git-send-email-devin122@gmail.com> <1311914994-20482-8-git-send-email-devin122@gmail.com> In-Reply-To: <1311914994-20482-8-git-send-email-devin122@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 07/24] qed: make qed_alloc_clusters round up offset to nearest cluster List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Devin Nakamura Cc: qemu-devel@nongnu.org Am 29.07.2011 06:49, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block/qed.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/block/qed.c b/block/qed.c > index 3970379..00cf895 100644 > --- a/block/qed.c > +++ b/block/qed.c > @@ -263,6 +263,9 @@ static int qed_read_string(BlockDriverState *file, uint64_t offset, size_t n, > */ > static uint64_t qed_alloc_clusters(BDRVQEDState *s, unsigned int n) > { > + s->file_size = (s->file_size + s->header.cluster_size -1) > + / s->header.cluster_size; > + s->file_size *= s->header.cluster_size; This looks a bit simpler: s->file_size = qed_start_of_cluster(s->file_size + s->header.cluster_size - 1); Kevin