From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QnuWT-0001P9-K3 for qemu-devel@nongnu.org; Mon, 01 Aug 2011 11:35:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QnuWS-0005V7-GZ for qemu-devel@nongnu.org; Mon, 01 Aug 2011 11:35:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QnuWS-0005V3-8J for qemu-devel@nongnu.org; Mon, 01 Aug 2011 11:35:16 -0400 Message-ID: <4E36C862.9010406@redhat.com> Date: Mon, 01 Aug 2011 17:38:10 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1311914994-20482-1-git-send-email-devin122@gmail.com> <1311914994-20482-23-git-send-email-devin122@gmail.com> In-Reply-To: <1311914994-20482-23-git-send-email-devin122@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 22/24] qemu-io: make map command use new block mapping function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Devin Nakamura Cc: qemu-devel@nongnu.org Am 29.07.2011 06:49, schrieb Devin Nakamura: > bdrv_get_mapping will be used when it is defined, > otherwise default to old behaviour. > > Signed-off-by: Devin Nakamura Hm, I think I would use a new command for this, like 'get_mapping'. The old 'map' command can still be useful even for formats supporting bdrv_get_mapping. You would use it whenever you are only interested which offsets are allocated, but don't care about the offsets in the image file to which they are mapped. This makes the output much shorter. Kevin