From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Supriya Kannery <supriyak@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change
Date: Mon, 01 Aug 2011 10:46:59 -0500 [thread overview]
Message-ID: <4E36CA73.3060504@codemonkey.ws> (raw)
In-Reply-To: <CAJSP0QXj8S_XPAgxHnW=dRqJqvXZq9GfJ-jX86_r-zhOS2tDRw@mail.gmail.com>
On 08/01/2011 10:44 AM, Stefan Hajnoczi wrote:
> On Mon, Aug 1, 2011 at 4:44 PM, Kevin Wolf<kwolf@redhat.com> wrote:
>> Am 01.08.2011 17:28, schrieb Anthony Liguori:
>>> On 08/01/2011 10:22 AM, Stefan Hajnoczi wrote:
>>>> I like the block_set approach.
>>>>
>>>> Anthony, Kevin, Supriya: Any thoughts?
>>>
>>> For the sake of overall QMP sanity, I think block_set_hostcache is
>>> really our only option.
>>
>> Ideally we should have blockdev_add, and blockdev_set would just take
>> the same arguments and update the given driver.
>>
>> But we don't have blockdev_add today, so whatever works for your as a
>> temporary solution...
>
> Anthony's point is that blockdev_set does not fit with QMP command
> discoverability.
It doesn't, but if we had a 'plug_set' that worked for devices and any
type of backends, we could have a single introspection mechanism.
But we should really try to avoid having every backend implement their
own ways of doing things.
Regards,
Anthony Liguori
>
> Stefan
>
next prev parent reply other threads:[~2011-08-01 15:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 11:30 [Qemu-devel] [V5 Patch 0/4]Qemu: Set host cache from cmdline and monitor Supriya Kannery
2011-07-27 11:30 ` [Qemu-devel] [V5 Patch 1/4]Qemu: Enhance "info block" to display host cache setting Supriya Kannery
2011-07-27 14:19 ` Stefan Hajnoczi
2011-07-28 10:39 ` Supriya Kannery
2011-07-27 11:30 ` [Qemu-devel] [V5 Patch 2/4]Qemu: qerrors for file reopen, data sync and cmd syntax Supriya Kannery
2011-07-27 11:30 ` [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change Supriya Kannery
2011-07-27 12:58 ` Anthony Liguori
2011-07-27 14:31 ` Stefan Hajnoczi
2011-07-27 16:02 ` Anthony Liguori
2011-07-28 9:29 ` Stefan Hajnoczi
2011-08-01 15:22 ` Stefan Hajnoczi
2011-08-01 15:28 ` Anthony Liguori
2011-08-01 15:34 ` Stefan Hajnoczi
2011-08-01 15:44 ` Kevin Wolf
2011-08-01 15:44 ` Anthony Liguori
2011-08-04 8:32 ` Supriya Kannery
2011-08-04 8:31 ` Stefan Hajnoczi
2011-08-04 9:33 ` Supriya Kannery
2011-08-04 9:17 ` Supriya Kannery
2011-08-01 15:44 ` Stefan Hajnoczi
2011-08-01 15:46 ` Anthony Liguori [this message]
2011-07-28 10:13 ` Supriya Kannery
2011-07-28 12:48 ` Anthony Liguori
2011-07-27 13:43 ` Michael Tokarev
2011-07-27 13:52 ` Anthony Liguori
2011-07-27 14:51 ` Stefan Hajnoczi
2011-07-28 10:23 ` Kevin Wolf
2011-07-28 13:10 ` Stefan Hajnoczi
2011-07-28 13:23 ` Kevin Wolf
2011-07-27 11:31 ` [Qemu-devel] [V5 Patch 4/4]Qemu: Add commandline -drive option 'hostcache' Supriya Kannery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E36CA73.3060504@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=supriyak@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).