From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45635)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qnuhr-0001Ca-0O
	for qemu-devel@nongnu.org; Mon, 01 Aug 2011 11:47:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qnuhq-0008IZ-2P
	for qemu-devel@nongnu.org; Mon, 01 Aug 2011 11:47:02 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:56751)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qnuhp-0008IP-S0
	for qemu-devel@nongnu.org; Mon, 01 Aug 2011 11:47:01 -0400
Received: by yxt3 with SMTP id 3so3947548yxt.4
	for <qemu-devel@nongnu.org>; Mon, 01 Aug 2011 08:47:01 -0700 (PDT)
Message-ID: <4E36CA73.3060504@codemonkey.ws>
Date: Mon, 01 Aug 2011 10:46:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20110727113000.25109.16204.sendpatchset@skannery>	<20110727113045.25109.54866.sendpatchset@skannery>	<4E300B8E.2020509@codemonkey.ws>	<CAJSP0QVsa30NWu++QdEMmLpa0Qaabmr+EuRcZuF6Fuuj7Co1hA@mail.gmail.com>	<4E3036AA.8030604@codemonkey.ws>	<CAJSP0QWYXimrhMrxp9m0o3MQjk=yG6bDv+xwO4Q3VUGr29Xazw@mail.gmail.com>	<CAJSP0QVhZm49rmzXJ486_+XVUiD3R_Toh91JjWPKz_Aq2wRS0Q@mail.gmail.com>	<4E36C608.2030107@codemonkey.ws>
	<4E36C9D3.4020803@redhat.com>
	<CAJSP0QXj8S_XPAgxHnW=dRqJqvXZq9GfJ-jX86_r-zhOS2tDRw@mail.gmail.com>
In-Reply-To: <CAJSP0QXj8S_XPAgxHnW=dRqJqvXZq9GfJ-jX86_r-zhOS2tDRw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for
 dynamic block params change
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Supriya Kannery <supriyak@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On 08/01/2011 10:44 AM, Stefan Hajnoczi wrote:
> On Mon, Aug 1, 2011 at 4:44 PM, Kevin Wolf<kwolf@redhat.com>  wrote:
>> Am 01.08.2011 17:28, schrieb Anthony Liguori:
>>> On 08/01/2011 10:22 AM, Stefan Hajnoczi wrote:
>>>> I like the block_set approach.
>>>>
>>>> Anthony, Kevin, Supriya: Any thoughts?
>>>
>>> For the sake of overall QMP sanity, I think block_set_hostcache is
>>> really our only option.
>>
>> Ideally we should have blockdev_add, and blockdev_set would just take
>> the same arguments and update the given driver.
>>
>> But we don't have blockdev_add today, so whatever works for your as a
>> temporary solution...
>
> Anthony's point is that blockdev_set does not fit with QMP command
> discoverability.

It doesn't, but if we had a 'plug_set' that worked for devices and any 
type of backends, we could have a single introspection mechanism.

But we should really try to avoid having every backend implement their 
own ways of doing things.

Regards,

Anthony Liguori

>
> Stefan
>