From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qny4I-0004Xj-3k for qemu-devel@nongnu.org; Mon, 01 Aug 2011 15:22:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qny4G-0007Ie-SY for qemu-devel@nongnu.org; Mon, 01 Aug 2011 15:22:26 -0400 Received: from mail-ww0-f53.google.com ([74.125.82.53]:40481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qny4G-0007I5-J5 for qemu-devel@nongnu.org; Mon, 01 Aug 2011 15:22:24 -0400 Received: by wwf26 with SMTP id 26so5342632wwf.10 for ; Mon, 01 Aug 2011 12:22:23 -0700 (PDT) Sender: Richard Henderson Message-ID: <4E36FCEA.3080201@twiddle.net> Date: Mon, 01 Aug 2011 12:22:18 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-19-git-send-email-avi@redhat.com> In-Reply-To: <1312135082-31985-19-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 18/39] ide: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/31/2011 10:57 AM, Avi Kivity wrote: > + pci_register_bar_region(dev, 3, PCI_BASE_ADDRESS_SPACE_IO, > + &d->cmd646_bar[2].cmd); Typo: cmd646_bar[1]. r~