From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qo9eO-0004xo-2y for qemu-devel@nongnu.org; Tue, 02 Aug 2011 03:44:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qo9eN-00038i-8w for qemu-devel@nongnu.org; Tue, 02 Aug 2011 03:44:28 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:64966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qo9eN-00038V-5L for qemu-devel@nongnu.org; Tue, 02 Aug 2011 03:44:27 -0400 Received: by gxk26 with SMTP id 26so4633960gxk.4 for ; Tue, 02 Aug 2011 00:44:26 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E37AAD2.2090706@redhat.com> Date: Tue, 02 Aug 2011 09:44:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <4E3673E3.1000201@redhat.com> <4E371406.7040109@redhat.com> In-Reply-To: <4E371406.7040109@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 1/3] separate thread for VM migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Umesh Deshpande Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, Juan Quintela On 08/01/2011 11:00 PM, Umesh Deshpande wrote: >> > I kept this in migration.c to call qemu_savevm_state_begin. (The way it > is done currently. i.e. to keep access to FdMigrationState in migration.c) > Calling it from buffered_file.c would be inconsistent in that sense. or > we will have to call it from the iothread before spawning the migration > thread. Right, I missed that. Perhaps you can call it the first time put_ready is called. > Also why is the separation between FdMigrationState and QEMUFileBuffered > is required. Is QEMUFileBuffered designed to use also for things other > than migration? No, but let's keep it this way for now. It may be an annoyance, but it also helps making a reusable architecture, and it can probably be cleaned up substantially with thread support. Paolo