Re: [Qemu-devel] [RFC] Alpha system patchset updated for Memory API, batch 2: PCI devices

[Avi Kivity <avi@redhat.com>]

On 08/02/2011 12:23 AM, Richard Henderson wrote:
> +
> +/* PCI IO reads/writes, to byte-word addressable memory.  */
> +/* ??? Doesn't handle multiple PCI busses.  */
> +
> +static uint64_t bw_io_read(void *opaque, target_phys_addr_t addr, unsigned size)
> +{
> +    switch (size) {
> +    case 1:
> +        return cpu_inb(addr);
> +    case 2:
> +        return cpu_inw(addr);
> +    case 4:
> +        return cpu_inl(addr);
> +    }
> +    abort();
> +}
> +
> +static void bw_io_write(void *opaque, target_phys_addr_t addr,
> +                        uint64_t val, unsigned size)
> +{
> +    switch (size) {
> +    case 1:
> +        cpu_outb(addr, val);
> +        break;
> +    case 2:
> +        cpu_outw(addr, val);
> +        break;
> +    case 4:
> +        cpu_outl(addr, val);
> +        break;
> +    default:
> +        abort();
> +    }
> +}
> +
> +const MemoryRegionOps alpha_pci_bw_io_ops = {
> +    .read = bw_io_read,
> +    .write = bw_io_write,
> +    .endianness = DEVICE_LITTLE_ENDIAN,
> +    .impl = {
> +        .min_access_size = 1,
> +        .max_access_size = 4,
> +    },
> +};
> +

The plan for this (and all mmio-mapped PCI_ADDRESS_SPACE_IO regions) is 
to map the I/O address space as a subregion of the PCI host bridge, 
eliminating this thunk.

-- 
error compiling committee.c: too many arguments to function