From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56733)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QoKU4-0003X9-UM
	for qemu-devel@nongnu.org; Tue, 02 Aug 2011 15:18:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QoKU3-00016r-Ss
	for qemu-devel@nongnu.org; Tue, 02 Aug 2011 15:18:32 -0400
Received: from e37.co.us.ibm.com ([32.97.110.158]:42943)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QoKU3-00016P-L3
	for qemu-devel@nongnu.org; Tue, 02 Aug 2011 15:18:31 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p72JFMX1016942
	for <qemu-devel@nongnu.org>; Tue, 2 Aug 2011 13:15:22 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	p72JIN1f186270
	for <qemu-devel@nongnu.org>; Tue, 2 Aug 2011 13:18:24 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p72DHsP9022249
	for <qemu-devel@nongnu.org>; Tue, 2 Aug 2011 07:17:55 -0600
Message-ID: <4E384D79.5070707@us.ibm.com>
Date: Tue, 02 Aug 2011 14:18:17 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1311278474-24336-1-git-send-email-lcapitulino@redhat.com>	<1311278474-24336-5-git-send-email-lcapitulino@redhat.com>	<CAETRQWnqyMRnnSKTY77=4sBpRnNR0Z2p=kAdhCJCMxPGv=Kizg@mail.gmail.com>
	<20110802160602.2a22445b@doriath>
In-Reply-To: <20110802160602.2a22445b@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Luiz Capitulino <lcapitulino@gmail.com>, TeLeMan <geleman@gmail.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>

On 08/02/2011 02:06 PM, Luiz Capitulino wrote:
> On Tue, 2 Aug 2011 10:03:30 +0800
> TeLeMan<geleman@gmail.com>  wrote:
>
>> This patch introduces "-mms-bitfields" cflag on MinGW but this cflag
>> breaks gcc packed structures("__attribute__((packed))"). For example,
>> slirp does not work on Win32.
>
> I'm not familiar with MinGW (or why glib would require that flag).
>
> Michael, Anthony, any idea?

ms-bitfields does packing of bitfields in a way compatible with MSVC. 
In order to call Windows API functions that use structures that have 
bitfields, you need to use ms-bitfields.

Slirp will need to be fixed to not depend on GCC bitfield layout.  This 
is one of the reasons why portable code should never use bitfields.

Regards,

Anthony Liguori