From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Stuart yoder <stuart.yoder@freescale.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] remove cross prefix from pkg-config command
Date: Wed, 03 Aug 2011 08:41:23 +0200 [thread overview]
Message-ID: <4E38ED93.4000302@redhat.com> (raw)
In-Reply-To: <4E38659C.7080008@mail.berlios.de>
On 08/02/2011 11:01 PM, Stefan Weil wrote:
>
> I run cross builds for arm, mips, powerpc and mingw.
> All of them use the cross prefix. When running make,
> I neither want to specify a special PATH nor a
> PKG_CONFIG_PATH. All I need is something like
> "make -C bin/arm" (each cross target has its own
> directory with the binaries).
>
> The general idea of your patch is ok, but maybe you
> can modify it so the cross prefix is used if there
> is no PKG_CONFIG_PATH set?
No, the PKG_CONFIG_PATH can be used by the user to add paths in his home
directory.
The right fix is to do something like
-pkg_config="${cross_prefix}${PKG_CONFIG-pkg-config}"
+pkg_config=${PKG_CONFIG-"${cross_prefix}pkg-config"}
and likewise for all other tools. Then Stuart can use
pkg_config=pkg-config. Stuart, can you do that?
Paolo
next prev parent reply other threads:[~2011-08-03 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 20:21 [Qemu-devel] [PATCH] remove cross prefix from pkg-config command Stuart yoder
2011-08-02 21:01 ` Stefan Weil
2011-08-03 6:41 ` Paolo Bonzini [this message]
2011-08-03 14:03 ` Yoder Stuart-B08248
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E38ED93.4000302@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stuart.yoder@freescale.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).