From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QoV8y-0004y9-Hi
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 02:41:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QoV8x-0002r8-7h
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 02:41:28 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:43295)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QoV8x-0002r4-2B
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 02:41:27 -0400
Received: by wwf26 with SMTP id 26so447578wwf.10
	for <qemu-devel@nongnu.org>; Tue, 02 Aug 2011 23:41:26 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E38ED93.4000302@redhat.com>
Date: Wed, 03 Aug 2011 08:41:23 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1312316473-22591-1-git-send-email-stuart.yoder@freescale.com>
	<4E38659C.7080008@mail.berlios.de>
In-Reply-To: <4E38659C.7080008@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] remove cross prefix from pkg-config command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Stuart yoder <stuart.yoder@freescale.com>, qemu-devel@nongnu.org

On 08/02/2011 11:01 PM, Stefan Weil wrote:
>
> I run cross builds for arm, mips, powerpc and mingw.
> All of them use the cross prefix. When running make,
> I neither want to specify a special PATH nor a
> PKG_CONFIG_PATH. All I need is something like
> "make -C bin/arm" (each cross target has its own
> directory with the binaries).
>
> The general idea of your patch is ok, but maybe you
> can modify it so the cross prefix is used if there
> is no PKG_CONFIG_PATH set?

No, the PKG_CONFIG_PATH can be used by the user to add paths in his home 
directory.

The right fix is to do something like

-pkg_config="${cross_prefix}${PKG_CONFIG-pkg-config}"
+pkg_config=${PKG_CONFIG-"${cross_prefix}pkg-config"}

and likewise for all other tools.  Then Stuart can use 
pkg_config=pkg-config.  Stuart, can you do that?

Paolo