From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QodIR-00040k-3J for qemu-devel@nongnu.org; Wed, 03 Aug 2011 11:23:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QodIQ-0007nc-0j for qemu-devel@nongnu.org; Wed, 03 Aug 2011 11:23:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QodIP-0007nU-LN for qemu-devel@nongnu.org; Wed, 03 Aug 2011 11:23:45 -0400 Message-ID: <4E3967FD.8000301@redhat.com> Date: Wed, 03 Aug 2011 18:23:41 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-21-git-send-email-avi@redhat.com> <20110801082600.GD5439@redhat.com> <4E367370.6070100@redhat.com> <20110801102322.GF5439@redhat.com> <20110803151635.GA15804@redhat.com> In-Reply-To: <20110803151635.GA15804@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/03/2011 06:16 PM, Michael S. Tsirkin wrote: > > > > Well, the reason we have this logic here, I think, is > > to make sure it runs before the guest accesses > > the configuration with a write access. > > > > I'm not sure why we don't do this in the init > > callback - Anthony? > > So the following should do this. > Anthony, could you ack please? > > Avi, this is on top of the memory API branch. > But since it's not exactly the same, > maybe this should go in *before* the memory API > patches, to make it easier to bisect etc? > > You decide. How can I decide? This is your area. I'll be happy to rebase if needed. -- error compiling committee.c: too many arguments to function