From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QosGS-0001eL-2p for qemu-devel@nongnu.org; Thu, 04 Aug 2011 03:22:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QosGR-0002LR-6W for qemu-devel@nongnu.org; Thu, 04 Aug 2011 03:22:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QosGQ-0002LJ-Vk for qemu-devel@nongnu.org; Thu, 04 Aug 2011 03:22:43 -0400 Message-ID: <4E3A48BE.2060302@redhat.com> Date: Thu, 04 Aug 2011 09:22:38 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1312326516-10117-1-git-send-email-aliguori@us.ibm.com> <4E389258.6040007@us.ibm.com> <4E398A44.8060507@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: Anthony Liguori , qemu-devel@nongnu.org On 08/03/2011 11:42 PM, Juan Quintela wrote: > > I can certainly limit the change to IDE if we think machine, floppy, > > and rtl8139 are safe. > > Ok, only IDE is broken, something done if we are not reverting the others. Floppy is broken too, and has the problem that the subsection is sent almost always. On the other hand IDE is only broken if we have subsections, and that is a rare case. So perhaps the best course of action is to only fix floppy, either as in your patch or by reverting 7d905f71. Let's keep IDE as it is broken as 0.14 was, and apply my patch to master. I'll rebase as soon as there is agreement this is the way to go. Paolo