From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qotru-0001HL-74 for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:05:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qotrs-00054U-JF for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:05:30 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:45792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qotrr-00050j-Sb for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:05:28 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp04.in.ibm.com (8.14.4/8.13.1) with ESMTP id p7495N1c018695 for ; Thu, 4 Aug 2011 14:35:23 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7495M2i2257128 for ; Thu, 4 Aug 2011 14:35:22 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7495LKu017594 for ; Thu, 4 Aug 2011 19:05:22 +1000 Message-ID: <4E3A6395.2080102@linux.vnet.ibm.com> Date: Thu, 04 Aug 2011 14:47:09 +0530 From: Supriya Kannery MIME-Version: 1.0 References: <20110727113000.25109.16204.sendpatchset@skannery> <20110727113045.25109.54866.sendpatchset@skannery> <4E300B8E.2020509@codemonkey.ws> <4E3036AA.8030604@codemonkey.ws> <4E36C608.2030107@codemonkey.ws> <4E36C9D3.4020803@redhat.com> <4E36C9F4.2080202@codemonkey.ws> <4E3A590B.1080609@linux.vnet.ibm.com> In-Reply-To: <4E3A590B.1080609@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change Reply-To: supriyak@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: supriyak@linux.vnet.ibm.com Cc: Kevin Wolf , Stefan Hajnoczi , Christoph Hellwig , qemu-devel@nongnu.org On 08/04/2011 02:02 PM, Supriya Kannery wrote: > On 08/01/2011 09:14 PM, Anthony Liguori wrote: >> On 08/01/2011 10:44 AM, Kevin Wolf wrote: >>> Am 01.08.2011 17:28, schrieb Anthony Liguori: >>>>> 2. Top-level command for each parameter (e.g. block_set_hostcache). >>>>> Supported parameters are easily discoverable via query-commands. If >>>>> individual block devices support different sets of parameters then >>>>> they may have to return -ENOTSUPP. >>>>> > > I am not able to find how "query-commands" is helping out > to programmatically find out all the supported parameters > of a specific command. When I tried out, "query-commands" > is listing all the supported command names. "query-xx" is > returning current settings related to command 'xx', > but not any information related to supported parameters > of 'xx'. > Am I missing something? > ok, I got it. "query commands" is not supposed to list out supported params for each command. Each block device parameter setting, when implemented as separate high level command, will get listed through query-commands. And this helps user to identify supported block parameters that can be changed. >> >> Regards, >> >> Anthony Liguori >> >>> >>> But we don't have blockdev_add today, so whatever works for your as a >>> temporary solution... >>> >>> Kevin >>> >> >> > >