From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Qou7N-0006dh-L5
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:21:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Qou7M-00021G-Ml
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:21:29 -0400
Received: from e28smtp05.in.ibm.com ([122.248.162.5]:58542)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Qou7M-0001yR-19
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:21:28 -0400
Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60])
	by e28smtp05.in.ibm.com (8.14.4/8.13.1) with ESMTP id p749LJbw030205
	for <qemu-devel@nongnu.org>; Thu, 4 Aug 2011 14:51:19 +0530
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p749LJU43862584
	for <qemu-devel@nongnu.org>; Thu, 4 Aug 2011 14:51:19 +0530
Received: from d28av04.in.ibm.com (loopback [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p749LIe4007623
	for <qemu-devel@nongnu.org>; Thu, 4 Aug 2011 19:21:19 +1000
Message-ID: <4E3A6753.9010708@linux.vnet.ibm.com>
Date: Thu, 04 Aug 2011 15:03:07 +0530
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20110727113000.25109.16204.sendpatchset@skannery>
	<20110727113045.25109.54866.sendpatchset@skannery>
	<4E300B8E.2020509@codemonkey.ws>
	<CAJSP0QVsa30NWu++QdEMmLpa0Qaabmr+EuRcZuF6Fuuj7Co1hA@mail.gmail.com>
	<4E3036AA.8030604@codemonkey.ws>
	<CAJSP0QWYXimrhMrxp9m0o3MQjk=yG6bDv+xwO4Q3VUGr29Xazw@mail.gmail.com>
	<CAJSP0QVhZm49rmzXJ486_+XVUiD3R_Toh91JjWPKz_Aq2wRS0Q@mail.gmail.com>
	<4E36C608.2030107@codemonkey.ws>	<4E36C9D3.4020803@redhat.com>
	<4E36C9F4.2080202@codemonkey.ws>	<4E3A590B.1080609@linux.vnet.ibm.com>
	<CAJSP0QX2gTXYSgSmt0ZYsCDm_DL-V0MCCmp1vnDjTetpZbmrJQ@mail.gmail.com>
In-Reply-To: <CAJSP0QX2gTXYSgSmt0ZYsCDm_DL-V0MCCmp1vnDjTetpZbmrJQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for
 dynamic block params change
Reply-To: supriyak@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On 08/04/2011 02:01 PM, Stefan Hajnoczi wrote:
> On Thu, Aug 4, 2011 at 9:32 AM, Supriya Kannery
> <supriyak@linux.vnet.ibm.com>  wrote:
>> On 08/01/2011 09:14 PM, Anthony Liguori wrote:
>>> On 08/01/2011 10:44 AM, Kevin Wolf wrote:
>>>> Am 01.08.2011 17:28, schrieb Anthony Liguori:
>>>>>> 2. Top-level command for each parameter (e.g. block_set_hostcache).
>>>>>> Supported parameters are easily discoverable via query-commands. If
>>>>>> individual block devices support different sets of parameters then
>>>>>> they may have to return -ENOTSUPP.
>>>>>>

>>>
>>> For now, using high level commands is the best we can do.
>> Will be modifying code to have 'block_set_hostcache' command implemented.
>> Along with that, planning to implement 'query-block_set_hostcache', that
>> returns current hostcache setting
>> for all the applicable block devices.
>
> I don't think a query command is necessary since query-block already
> reports this information.
>

ok

> Stefan