From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QoueK-00066K-Kx
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:55:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QoueJ-0002BV-MI
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:55:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QoueJ-0002Ah-F9
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 05:55:31 -0400
Message-ID: <4E3A6C8C.8060304@redhat.com>
Date: Thu, 04 Aug 2011 12:55:24 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1312384643-581-1-git-send-email-lcapitulino@redhat.com>
	<1312384643-581-3-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1312384643-581-3-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper
	QemuState type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: blauwirbel@gmail.com, amit.shah@redhat.com, aliguori@us.ibm.com, jan.kiszka@web.de, qemu-devel@nongnu.org

On 08/03/2011 06:17 PM, Luiz Capitulino wrote:
> @@ -9,6 +9,20 @@
>   #include "notify.h"
>
>   /* vl.c */
> +
> +typedef enum {
> +    QSTATE_DEBUG,         /* qemu is running under gdb */
> +    QSTATE_INTERROR,      /* paused due to an internal error */
> +    QSTATE_IOERROR,       /* paused due to an I/O error */
> +    QSTATE_PAUSED,        /* paused by the user (ie. the 'stop' command) */
> +    QSTATE_PREMIGRATE,    /* paused preparing to finish migrate */
> +    QSTATE_RESTVM,        /* paused restoring the VM state */
> +    QSTATE_RUNNING,       /* qemu is running */
> +    QSTATE_SAVEVM,        /* paused saving VM state */
> +    QSTATE_SHUTDOWN,      /* guest shut down and -no-shutdown is in use */
> +    QSTATE_WATCHDOG       /* watchdog fired and qemu is configured to pause */
> +} QemuState;
> +
>   extern const char *bios_name;
>

Why "QemuState"?  In general, "qemu" can be inferred from the fact that 
we're in qemu.git.  Suggest "RunState".

Second, these states can coexist.  A user may pause the VM 
simultaneously with the watchdog firing or entering premigrate state.  
In fact, with multiple monitors, each monitor can pause and resume the 
vm independently.

So I think we should keep a reference count instead of just a start/stop 
state.  Perhaps

vm_stop(QemuState s)
{
     ++stopcount[s];
}

vm_is_stopped()
{
     for (s in states)
           if (stopcount[s])
               return true;
     return false;
}

-- 
error compiling committee.c: too many arguments to function