From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoyDF-0000r9-7n for qemu-devel@nongnu.org; Thu, 04 Aug 2011 09:43:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoyDD-0006Es-SI for qemu-devel@nongnu.org; Thu, 04 Aug 2011 09:43:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoyDD-0006Eo-L5 for qemu-devel@nongnu.org; Thu, 04 Aug 2011 09:43:47 -0400 Message-ID: <4E3AA2C2.30902@redhat.com> Date: Thu, 04 Aug 2011 15:46:42 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> <1312361359-15445-2-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 04.08.2011 15:35, schrieb Stefan Hajnoczi: > On Wed, Aug 3, 2011 at 9:49 AM, Paolo Bonzini wrote: >> In fact, if the HBA's transfer_data callback goes on with scsi_req_continue >> the request will be completed successfully instead of showing a failure. >> It can even cause a segmentation fault. >> >> An easy way to trigger it is "eject -f cd" during installation (during media >> test if the installer does something like that). >> >> Signed-off-by: Paolo Bonzini >> --- >> hw/scsi-disk.c | 3 --- >> 1 files changed, 0 insertions(+), 3 deletions(-) >> >> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c >> index f42a5d1..814bf74 100644 >> --- a/hw/scsi-disk.c >> +++ b/hw/scsi-disk.c >> @@ -217,9 +217,6 @@ static int scsi_handle_rw_error(SCSIDiskReq *r, int error, int type) >> bdrv_mon_event(s->bs, BDRV_ACTION_STOP, is_read); >> vm_stop(VMSTOP_DISKFULL); >> } else { >> - if (type == SCSI_REQ_STATUS_RETRY_READ) { >> - scsi_req_data(&r->req, 0); >> - } >> switch (error) { >> case ENOMEM: >> scsi_command_complete(r, CHECK_CONDITION, > > Kevin, do you remember why you added this in 5dba48a8? No, I don't remember anything specific, I just tried to leave the rerror=report case unchanged. This looks like it's moved code from scsi_read_complete. Kevin