From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qoywh-00051O-Ml for qemu-devel@nongnu.org; Thu, 04 Aug 2011 10:30:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qoywg-0007pN-Fu for qemu-devel@nongnu.org; Thu, 04 Aug 2011 10:30:47 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:53858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qoywg-0007pF-8L for qemu-devel@nongnu.org; Thu, 04 Aug 2011 10:30:46 -0400 Received: by pzk37 with SMTP id 37so2518036pzk.29 for ; Thu, 04 Aug 2011 07:30:44 -0700 (PDT) Message-ID: <4E3AAD0F.4040502@codemonkey.ws> Date: Thu, 04 Aug 2011 09:30:39 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1312326516-10117-1-git-send-email-aliguori@us.ibm.com> <4E389258.6040007@us.ibm.com> <4E398A44.8060507@codemonkey.ws> <4E3A48BE.2060302@redhat.com> <4E3A9CA0.9090706@codemonkey.ws> <4E3AA82B.2030300@redhat.com> In-Reply-To: <4E3AA82B.2030300@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org, quintela@redhat.com On 08/04/2011 09:09 AM, Kevin Wolf wrote: > Am 04.08.2011 15:20, schrieb Anthony Liguori: >> On 08/04/2011 02:22 AM, Paolo Bonzini wrote: >>> On 08/03/2011 11:42 PM, Juan Quintela wrote: >>>>> I can certainly limit the change to IDE if we think machine, floppy, >>>>> and rtl8139 are safe. >>>> >>>> Ok, only IDE is broken, something done if we are not reverting the >>>> others. >>> >>> Floppy is broken too, and has the problem that the subsection is sent >>> almost always. On the other hand IDE is only broken if we have >>> subsections, and that is a rare case. >>> >>> So perhaps the best course of action is to only fix floppy, either as in >>> your patch or by reverting 7d905f71. Let's keep IDE as it is broken as >>> 0.14 was, and apply my patch to master. >> >> >> Hrm, so the idea is to keep IDE broken but not worry because it is so >> rare? Why not just force the subsection to be sent? > > Wouldn't that only introduce more broken cases in which the destination > thinks it has successfully read the whole VM state when in fact it has > only been confused by a subsection? Force the subsection to be sent and increment the version number. Regards, Anthony Liguori > > Kevin >