From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp0Ly-0007gn-LJ for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qp0Lu-0002S3-T9 for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:00:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp0Lu-0002RY-Cz for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:00:54 -0400 Message-ID: <4E3AC230.1070109@redhat.com> Date: Thu, 04 Aug 2011 19:00:48 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312208590-25502-1-git-send-email-aliguori@us.ibm.com> <1312208590-25502-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1312208590-25502-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , Hans de Goede , qemu-devel@nongnu.org On 08/01/2011 05:22 PM, Anthony Liguori wrote: > The char layer is confusing. There is a front-end, typically a device, that > can send and receive data. The front-end sends data by calling > qemu_chr_write(). > > The back-end, typically created via -chardev, can also send and receive data. > Oddly, it sends data by calling qemu_chr_read(). > > Let's be explicit about which function is for which party. A different way to accomplish this would be to have each pipe expose two interfaces (a front end and a back end), and use the same functions for both. Just like a unix pipe. The back end interface would typically be an internal object. -- error compiling committee.c: too many arguments to function