From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:32885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qp0fr-0002TC-BR
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:21:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qp0fq-0007Tj-33
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:21:31 -0400
Received: from mail-pz0-f42.google.com ([209.85.210.42]:51551)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qp0fp-0007TT-Qn
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:21:29 -0400
Received: by pzk37 with SMTP id 37so2682788pzk.29
	for <qemu-devel@nongnu.org>; Thu, 04 Aug 2011 09:21:28 -0700 (PDT)
Message-ID: <4E3AC705.40808@codemonkey.ws>
Date: Thu, 04 Aug 2011 11:21:25 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1312208590-25502-1-git-send-email-aliguori@us.ibm.com>	<1312208590-25502-2-git-send-email-aliguori@us.ibm.com>	<4E3AC230.1070109@redhat.com>
	<4E3AC498.6000404@codemonkey.ws> <4E3AC561.7070902@redhat.com>
In-Reply-To: <4E3AC561.7070902@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write()
	to	qemu_chr_fe_write()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Hans de Goede <hdegoede@redhat.com>, qemu-devel@nongnu.org

On 08/04/2011 11:14 AM, Avi Kivity wrote:
> On 08/04/2011 07:11 PM, Anthony Liguori wrote:
>> On 08/04/2011 11:00 AM, Avi Kivity wrote:
>>> On 08/01/2011 05:22 PM, Anthony Liguori wrote:
>>>> The char layer is confusing. There is a front-end, typically a device,
>>>> that
>>>> can send and receive data. The front-end sends data by calling
>>>> qemu_chr_write().
>>>>
>>>> The back-end, typically created via -chardev, can also send and
>>>> receive data.
>>>> Oddly, it sends data by calling qemu_chr_read().
>>>>
>>>> Let's be explicit about which function is for which party.
>>>
>>> A different way to accomplish this would be to have each pipe expose two
>>> interfaces (a front end and a back end), and use the same functions for
>>> both. Just like a unix pipe.
>>
>> This is exactly what I'm trying to do. This is why I decided to do
>> this before QOM, because this will change the relationships between
>> objects dramatically since you no longer need to subclass
>> CharDriverState since it's just being used as a pipe.
>
> Yes, I'm just talking about the function names, not about the
> implementation.
>
> qemu_chr_fe_write(chr,...) -> qemu_chr_write(chr, ...)
> qemu_chr_be_write(chr, ...) -> qemu_chr_write(&chr->backend, ...)

These are just the incremental patches to get us there.  Some more 
refactoring is needed to get to a single function.

Regards,

Anthony Liguori