From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qp0hK-0003v1-FN
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:23:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qp0hJ-0007nr-9n
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:23:02 -0400
Received: from mail-pz0-f42.google.com ([209.85.210.42]:62450)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qp0hJ-0007ne-1m
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:23:01 -0400
Received: by pzk37 with SMTP id 37so2684926pzk.29
	for <qemu-devel@nongnu.org>; Thu, 04 Aug 2011 09:23:00 -0700 (PDT)
Message-ID: <4E3AC761.4090001@codemonkey.ws>
Date: Thu, 04 Aug 2011 11:22:57 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1312208590-25502-1-git-send-email-aliguori@us.ibm.com>	<1312208590-25502-2-git-send-email-aliguori@us.ibm.com>	<4E3AC230.1070109@redhat.com>
	<4E3AC498.6000404@codemonkey.ws>	<4E3AC561.7070902@redhat.com>
	<4E3AC631.3070606@redhat.com>
In-Reply-To: <4E3AC631.3070606@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write()
	to	qemu_chr_fe_write()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Hans de Goede <hdegoede@redhat.com>, qemu-devel@nongnu.org

On 08/04/2011 11:17 AM, Avi Kivity wrote:
> On 08/04/2011 07:14 PM, Avi Kivity wrote:
>>
>> Yes, I'm just talking about the function names, not about the
>> implementation.
>>
>> qemu_chr_fe_write(chr,...) -> qemu_chr_write(chr, ...)
>> qemu_chr_be_write(chr, ...) -> qemu_chr_write(&chr->backend, ...)
>>
>
> And, if you want an internal pipe:
>
> QemuPipeEndpoint pipe1, pipe2;
>
> qemu_chr_pipe_init(&pipe0, &pipe1);
>
> so clients don't have to choose between frontend and backend. Finally
> you can connect COM1: to COM2: with a qemu-provided null modem cable!

Yes, that's exactly the goal :-)

The only problem left to be resolved is how to handle ioctl(). 
qemu_chr_ioctl() forces asymmetry today.

I think if we merge ioctl into qemu_chr_event() by adding a return and 
data payload, it'll make the semantics be synchronous messaging and 
it'll be easy to make ioctl work.

Regards,

Anthony Liguori

>