From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp33B-00012A-6m for qemu-devel@nongnu.org; Thu, 04 Aug 2011 14:53:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qp33A-0006U0-A3 for qemu-devel@nongnu.org; Thu, 04 Aug 2011 14:53:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp339-0006Tn-VZ for qemu-devel@nongnu.org; Thu, 04 Aug 2011 14:53:44 -0400 Message-ID: <4E3AEAB3.9030004@redhat.com> Date: Thu, 04 Aug 2011 20:53:39 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1312470626-25872-1-git-send-email-kraxel@redhat.com> <1312470626-25872-2-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/16] re-activate usb-host for bsd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 08/04/11 20:50, Blue Swirl wrote: > On Thu, Aug 4, 2011 at 3:10 PM, Gerd Hoffmann wrote: >> A bunch of code was disabled via #if 0, for a quite long time (since >> Sept 2009). Surprisingly the code builds just fine when they are >> removed (tested on OpenBSD). /me wonders nevertheless whenever there >> are any users of those bits when this went unnoticed for almost two >> years ... > > I added the #ifdeffery. The build was broken by some previous commit > but since my OpenBSD machine doesn't have USB so I couldn't test it. > Did you test if USB works now or just that code builds? Did just a build test, with OpenBSD itself in a virtual machine. cheers, Gerd