From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QpL55-0007pZ-5v
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 10:08:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QpL53-0006Eb-V5
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 10:08:55 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:33664)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QpL53-0006ET-SZ
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 10:08:53 -0400
Received: by yxt3 with SMTP id 3so1974490yxt.4
	for <qemu-devel@nongnu.org>; Fri, 05 Aug 2011 07:08:53 -0700 (PDT)
Message-ID: <4E3BF971.6000708@codemonkey.ws>
Date: Fri, 05 Aug 2011 09:08:49 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1312463195-13605-1-git-send-email-avi@redhat.com>
	<1312463195-13605-6-git-send-email-avi@redhat.com>
In-Reply-To: <1312463195-13605-6-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 05/39] cirrus: simplify mmio BAR access
 functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>

On 08/04/2011 08:06 AM, Avi Kivity wrote:
> Make use of the memory API's ability to satisfy multi-byte accesses via
> multiple single-byte accesses.
>
> Reviewed-by: Richard Henderson<rth@twiddle.net>
> Signed-off-by: Avi Kivity<avi@redhat.com>

> -static uint64_t cirrus_mmio_read(void *opaque, target_phys_addr_t addr,
> -                                 unsigned size)
> -{
> -    CirrusVGAState *s = opaque;
> -
> -    switch (size) {
> -    case 1: return cirrus_mmio_readb(s, addr);
> -    case 2: return cirrus_mmio_readw(s, addr);
> -    case 4: return cirrus_mmio_readl(s, addr);
> -    default: abort();
> -    }
> -};
> -
> -static void cirrus_mmio_write(void *opaque, target_phys_addr_t addr,
> -                              uint64_t data, unsigned size)
> -{
> -    CirrusVGAState *s = opaque;
> -
> -    switch (size) {
> -    case 1: return cirrus_mmio_writeb(s, addr, data);
> -    case 2: return cirrus_mmio_writew(s, addr, data);
> -    case 4: return cirrus_mmio_writel(s, addr, data);
> -    default: abort();
> -    }
> -};
> -
>   static const MemoryRegionOps cirrus_mmio_io_ops = {
>       .read = cirrus_mmio_read,
>       .write = cirrus_mmio_write,
>       .endianness = DEVICE_LITTLE_ENDIAN,
> +    .impl = {
> +        .min_access_size = 1,
> +        .max_access_size = 1,
> +    },
>   };

Nevermind, I get the lack of old_mmio usage now.

Regards,

Anthony Liguori

>   /* load/save state */