From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpLBm-0003mk-7B for qemu-devel@nongnu.org; Fri, 05 Aug 2011 10:15:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpLBl-0007QQ-3c for qemu-devel@nongnu.org; Fri, 05 Aug 2011 10:15:50 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:44166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpLBk-0007QH-Rv for qemu-devel@nongnu.org; Fri, 05 Aug 2011 10:15:49 -0400 Received: by gwb19 with SMTP id 19so274279gwb.4 for ; Fri, 05 Aug 2011 07:15:48 -0700 (PDT) Message-ID: <4E3BFB11.7090407@codemonkey.ws> Date: Fri, 05 Aug 2011 09:15:45 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-11-git-send-email-avi@redhat.com> In-Reply-To: <1312463195-13605-11-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 10/39] Integrate I/O memory regions into qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/04/2011 08:06 AM, Avi Kivity wrote: > get_system_io() returns the root I/O memory region. > > Reviewed-by: Richard Henderson > Signed-off-by: Avi Kivity > --- > exec-memory.h | 2 ++ > exec.c | 10 ++++++++++ > 2 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/exec-memory.h b/exec-memory.h > index c439aba..999fd69 100644 > --- a/exec-memory.h > +++ b/exec-memory.h > @@ -28,6 +28,8 @@ > */ > MemoryRegion *get_system_memory(void); > > +MemoryRegion *get_system_io(void); > + Could you add a doc comment for this function? Regards, Anthony Liguori