From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpMJm-00031G-T1 for qemu-devel@nongnu.org; Fri, 05 Aug 2011 11:28:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpMJl-0008SP-Iy for qemu-devel@nongnu.org; Fri, 05 Aug 2011 11:28:10 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:60195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpMJl-0008SL-BW for qemu-devel@nongnu.org; Fri, 05 Aug 2011 11:28:09 -0400 Received: by gxk26 with SMTP id 26so205331gxk.4 for ; Fri, 05 Aug 2011 08:28:08 -0700 (PDT) Message-ID: <4E3C0C03.7010205@codemonkey.ws> Date: Fri, 05 Aug 2011 10:28:03 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-26-git-send-email-avi@redhat.com> In-Reply-To: <1312463195-13605-26-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 25/39] ne2000: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/04/2011 08:06 AM, Avi Kivity wrote: > Reviewed-by: Richard Henderson > Signed-off-by: Avi Kivity > --- > hw/ne2000-isa.c | 14 +++------- > hw/ne2000.c | 77 +++++++++++++++++++++++++++++++++++++----------------- > hw/ne2000.h | 8 +---- > 3 files changed, 59 insertions(+), 40 deletions(-) > > diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c > index e41dbba..ce7b365 100644 > --- a/hw/ne2000-isa.c > +++ b/hw/ne2000-isa.c > @@ -61,24 +61,18 @@ static const VMStateDescription vmstate_isa_ne2000 = { > } > }; > > +#include "exec-memory.h" > + Should be at the top of the file. Regards, Anthony Liguori