From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpMUX-0007rJ-SZ for qemu-devel@nongnu.org; Fri, 05 Aug 2011 11:39:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpMUW-00027h-Vx for qemu-devel@nongnu.org; Fri, 05 Aug 2011 11:39:17 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:60168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpMUW-00027N-Td for qemu-devel@nongnu.org; Fri, 05 Aug 2011 11:39:16 -0400 Received: by qyk31 with SMTP id 31so1143941qyk.4 for ; Fri, 05 Aug 2011 08:39:14 -0700 (PDT) Sender: Richard Henderson Message-ID: <4E3C0E9E.2090203@twiddle.net> Date: Fri, 05 Aug 2011 08:39:10 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1311448659-17424-1-git-send-email-rth@twiddle.net> <1311448659-17424-2-git-send-email-rth@twiddle.net> <4E2C1E0D.4050100@codemonkey.ws> <4E2C4B5B.9030402@twiddle.net> <4E2C6AC0.3010203@codemonkey.ws> <20110804235831.GD2601@zapo> In-Reply-To: <20110804235831.GD2601@zapo> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] Export the unassigned_mem read/write functions. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: Avi Kivity , qemu-devel@nongnu.org On 08/04/2011 04:58 PM, Edgar E. Iglesias wrote: > QEMU only models the data lanes so I think Richards patch is quite OK > because it brings the decission back to the CPU model. > > I would prefer though, if the new Memory API would let devices pass > ctrl data back to the CPU in addition to the data lanes. That would > probably involve quite a bit of work though. CC:ing Avi, you might > have more input on this. Amusingly, after having updated my system to Avi's tree, I find I don't need the unassigned_mem_read[bwl] helpers anymore, but only the cpu_unassigned_access function, which is already exported. It would be nice if the new api allowed signaling of errors, but I can't think of a really nice way of doing that. r~