From: Anthony Liguori <anthony@codemonkey.ws>
To: Stuart yoder <stuart.yoder@freescale.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] when overriding default tool names don't add cross-prefix
Date: Fri, 05 Aug 2011 11:58:46 -0500 [thread overview]
Message-ID: <4E3C2146.8020204@codemonkey.ws> (raw)
In-Reply-To: <1312495808-22521-1-git-send-email-stuart.yoder@freescale.com>
On 08/04/2011 05:10 PM, Stuart yoder wrote:
> From: Stuart Yoder<stuart.yoder@freescale.com>
>
> When overriding a tool name via a shell variable, don't
> tack on the cross-prefix. This specifically allows the
> pkg-config command to be overridden and work where it
> does not exist in some cross build environments.
>
> Signed-off-by: Stuart Yoder<stuart.yoder@freescale.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> configure | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/configure b/configure
> index 38e3724..ad522f2 100755
> --- a/configure
> +++ b/configure
> @@ -217,14 +217,14 @@ done
> # Using uname is really, really broken. Once we have the right set of checks
> # we can eliminate it's usage altogether
>
> -cc="${cross_prefix}${CC-gcc}"
> -ar="${cross_prefix}${AR-ar}"
> -objcopy="${cross_prefix}${OBJCOPY-objcopy}"
> -ld="${cross_prefix}${LD-ld}"
> -strip="${cross_prefix}${STRIP-strip}"
> -windres="${cross_prefix}${WINDRES-windres}"
> -pkg_config="${cross_prefix}${PKG_CONFIG-pkg-config}"
> -sdl_config="${cross_prefix}${SDL_CONFIG-sdl-config}"
> +cc="${CC-${cross_prefix}gcc}"
> +ar="${AR-${cross_prefix}ar}"
> +objcopy="${OBJCOPY-${cross_prefix}objcopy}"
> +ld="${LD-${cross_prefix}ld}"
> +strip="${STRIP-${cross_prefix}strip}"
> +windres="${WINDRES-${cross_prefix}windres}"
> +pkg_config="${PKG_CONFIG-${cross_prefix}pkg-config}"
> +sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
>
> # default flags for all hosts
> QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
prev parent reply other threads:[~2011-08-05 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 22:10 [Qemu-devel] [PATCH] when overriding default tool names don't add cross-prefix Stuart yoder
2011-08-05 16:58 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3C2146.8020204@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).