From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QpNjb-0006g8-1J
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 12:58:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QpNjX-0004PR-04
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 12:58:54 -0400
Received: from mail-pz0-f42.google.com ([209.85.210.42]:61941)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QpNjW-0004Om-LF
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 12:58:50 -0400
Received: by pzk37 with SMTP id 37so4939380pzk.29
	for <qemu-devel@nongnu.org>; Fri, 05 Aug 2011 09:58:49 -0700 (PDT)
Message-ID: <4E3C2146.8020204@codemonkey.ws>
Date: Fri, 05 Aug 2011 11:58:46 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1312495808-22521-1-git-send-email-stuart.yoder@freescale.com>
In-Reply-To: <1312495808-22521-1-git-send-email-stuart.yoder@freescale.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] when overriding default tool names don't
 add cross-prefix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart yoder <stuart.yoder@freescale.com>
Cc: qemu-devel@nongnu.org

On 08/04/2011 05:10 PM, Stuart yoder wrote:
> From: Stuart Yoder<stuart.yoder@freescale.com>
>
> When overriding a tool name via a shell variable, don't
> tack on the cross-prefix.  This specifically allows the
> pkg-config command to be overridden and work where it
> does not exist in some cross build environments.
>
> Signed-off-by: Stuart Yoder<stuart.yoder@freescale.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   configure |   16 ++++++++--------
>   1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/configure b/configure
> index 38e3724..ad522f2 100755
> --- a/configure
> +++ b/configure
> @@ -217,14 +217,14 @@ done
>   # Using uname is really, really broken.  Once we have the right set of checks
>   # we can eliminate it's usage altogether
>
> -cc="${cross_prefix}${CC-gcc}"
> -ar="${cross_prefix}${AR-ar}"
> -objcopy="${cross_prefix}${OBJCOPY-objcopy}"
> -ld="${cross_prefix}${LD-ld}"
> -strip="${cross_prefix}${STRIP-strip}"
> -windres="${cross_prefix}${WINDRES-windres}"
> -pkg_config="${cross_prefix}${PKG_CONFIG-pkg-config}"
> -sdl_config="${cross_prefix}${SDL_CONFIG-sdl-config}"
> +cc="${CC-${cross_prefix}gcc}"
> +ar="${AR-${cross_prefix}ar}"
> +objcopy="${OBJCOPY-${cross_prefix}objcopy}"
> +ld="${LD-${cross_prefix}ld}"
> +strip="${STRIP-${cross_prefix}strip}"
> +windres="${WINDRES-${cross_prefix}windres}"
> +pkg_config="${PKG_CONFIG-${cross_prefix}pkg-config}"
> +sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
>
>   # default flags for all hosts
>   QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"