From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QpPEL-0007Gs-5o
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 14:34:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QpPEK-00014K-8L
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 14:34:45 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:37344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QpPEK-00014C-4G
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 14:34:44 -0400
Received: by qyk31 with SMTP id 31so1235811qyk.4
	for <qemu-devel@nongnu.org>; Fri, 05 Aug 2011 11:34:43 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E3C37C1.6080207@twiddle.net>
Date: Fri, 05 Aug 2011 11:34:41 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1312554976-5822-1-git-send-email-anthony.perard@citrix.com>
	<4E3C1FFF.8070409@codemonkey.ws>
In-Reply-To: <4E3C1FFF.8070409@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is
 set.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony PERARD <anthony.perard@citrix.com>, QEMU-devel <qemu-devel@nongnu.org>

On 08/05/2011 09:53 AM, Anthony Liguori wrote:
>> +    if (val&  E1000_CTRL_RST) {
> 
> You'll break some GCCs with -Wall -Werror with this.  Please do:
> 
> if ((val & E1000_CTRL_RST)) {

Err, really?  What versions?

I don't recall that ever being true.


r~