From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Qpicv-0003iZ-Vw
	for qemu-devel@nongnu.org; Sat, 06 Aug 2011 11:17:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Qpicv-0006ht-2S
	for qemu-devel@nongnu.org; Sat, 06 Aug 2011 11:17:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Qpicu-0006hH-Pq
	for qemu-devel@nongnu.org; Sat, 06 Aug 2011 11:17:25 -0400
Message-ID: <4E3D5AFF.3010605@redhat.com>
Date: Sat, 06 Aug 2011 17:17:19 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1312285630-15507-1-git-send-email-pbonzini@redhat.com>
	<1312285630-15507-2-git-send-email-pbonzini@redhat.com>
	<4E3C12BD.1090105@codemonkey.ws>
In-Reply-To: <4E3C12BD.1090105@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] ptimer: move declarations to ptimer.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 08/05/2011 05:56 PM, Anthony Liguori wrote:
> On 08/02/2011 06:47 AM, Paolo Bonzini wrote:
>> Since the next patch will move VMState declarations for ptimers out
>> of hw/hw.h, prepare a place for them.
>>
>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>> ---
>> hw/arm_timer.c | 1 +
>> hw/etraxfs_timer.c | 1 +
>> hw/grlib_apbuart.c | 1 +
>> hw/grlib_gptimer.c | 1 +
>> hw/lan9118.c | 1 +
>> hw/leon3.c | 1 +
>> hw/lm32_timer.c | 1 +
>> hw/mcf5206.c | 1 +
>> hw/mcf5208.c | 1 +
>> hw/milkymist-sysctl.c | 1 +
>> hw/musicpal.c | 1 +
>> hw/ptimer.c | 1 +
>> hw/ptimer.h | 27 +++++++++++++++++++++++++++
>> hw/sh_timer.c | 1 +
>> hw/slavio_timer.c | 1 +
>
> With this series applied, I get:
>
> In file included from /home/anthony/git/qemu/hw/slavio_timer.c:27:0:
> /home/anthony/git/qemu/hw/ptimer.h:27:33: error: expected =E2=80=98=3D=E2=
=80=99, =E2=80=98,=E2=80=99, =E2=80=98;=E2=80=99,
> =E2=80=98asm=E2=80=99 or =E2=80=98__attribute__=E2=80=99 before =E2=80=98=
vmstate_ptimer=E2=80=99
> /home/anthony/git/qemu/hw/slavio_timer.c:338:9: error: =E2=80=98vmstate=
_ptimer=E2=80=99
> undeclared here (not in a function)
> make[1]: *** [slavio_timer.o] Error 1
> make: *** [subdir-sparc-softmmu] Error 2

Never attribute to chance what can be attributed to stupidity.  Forgot I=20
had configured with --target-list.

Paolo