From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpydV-0007V6-4u for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:23:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpydU-0003rS-2p for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:23:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpydT-0003rO-Qq for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:23:04 -0400 Message-ID: <4E3E4B63.3020108@redhat.com> Date: Sun, 07 Aug 2011 11:22:59 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-3-git-send-email-avi@redhat.com> <4E3BF5E9.5050504@codemonkey.ws> In-Reply-To: <4E3BF5E9.5050504@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 02/39] pci: add API to get a BAR's mapped address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/05/2011 04:53 PM, Anthony Liguori wrote: > On 08/04/2011 08:05 AM, Avi Kivity wrote: >> This is a hack, for devices that have a back-channel to read this >> address back outside the normal configuration mechanisms, such >> as VMware svga. >> >> Reviewed-by: Richard Henderson >> Signed-off-by: Avi Kivity > > Can we add a comment to the header file to this effect? I think I'll just update the changelog. There is nothing hacky about the API - it just reads documented PCI registers - it's the hardware that needs the API that's hacky, since the value in the registers doesn't mean much. -- error compiling committee.c: too many arguments to function