From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpyfT-0008VK-HC for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:25:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpyfS-0004Hf-Jd for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:25:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpyfS-0004HM-BU for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:25:06 -0400 Message-ID: <4E3E4BDD.6090201@redhat.com> Date: Sun, 07 Aug 2011 11:25:01 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-6-git-send-email-avi@redhat.com> <4E3BF971.6000708@codemonkey.ws> In-Reply-To: <4E3BF971.6000708@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 05/39] cirrus: simplify mmio BAR access functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/05/2011 05:08 PM, Anthony Liguori wrote: >> .read = cirrus_mmio_read, >> .write = cirrus_mmio_write, >> .endianness = DEVICE_LITTLE_ENDIAN, >> + .impl = { >> + .min_access_size = 1, >> + .max_access_size = 1, >> + }, >> }; > static const MemoryRegionOps cirrus_mmio_io_ops = { > > Nevermind, I get the lack of old_mmio usage now. Well, the real reason was that old_mmio didn't exist when I wrote the patchset, and I didn't want to undo all this work when it appeared. -- error compiling committee.c: too many arguments to function