From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48189)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qpz9x-0005fP-8b
	for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:56:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qpz9w-0000rY-Fn
	for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:56:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qpz9w-0000rS-7Y
	for qemu-devel@nongnu.org; Sun, 07 Aug 2011 04:56:36 -0400
Message-ID: <4E3E533E.2060402@redhat.com>
Date: Sun, 07 Aug 2011 11:56:30 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1312463195-13605-1-git-send-email-avi@redhat.com>
	<1312463195-13605-14-git-send-email-avi@redhat.com>
	<4E3BFC6C.7010403@codemonkey.ws>
In-Reply-To: <4E3BFC6C.7010403@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 13/39] rtl8139: convert to memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>

On 08/05/2011 05:21 PM, Anthony Liguori wrote:
>> +    { 0, 0x100, 4, .write = rtl8139_ioport_writel, },
>> +    PORTIO_END
>
>
> Hrm, I missed this #define when it was introduced.
>
> Elsewhere we use:
>
> VMSTATE_END_OF_LIST()
> DEFINE_PROP_END_OF_LIST()
>
> For consistency, we ought to use PORTIO_END_OF_LIST()

Okay, fixed.

-- 
error compiling committee.c: too many arguments to function