From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpzXj-0000ps-VP for qemu-devel@nongnu.org; Sun, 07 Aug 2011 05:21:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpzXj-0004er-4D for qemu-devel@nongnu.org; Sun, 07 Aug 2011 05:21:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpzXi-0004el-TZ for qemu-devel@nongnu.org; Sun, 07 Aug 2011 05:21:11 -0400 Message-ID: <4E3E5901.5010405@redhat.com> Date: Sun, 07 Aug 2011 12:21:05 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-26-git-send-email-avi@redhat.com> <4E3C0C03.7010205@codemonkey.ws> In-Reply-To: <4E3C0C03.7010205@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 25/39] ne2000: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/05/2011 06:28 PM, Anthony Liguori wrote: >> diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c >> index e41dbba..ce7b365 100644 >> --- a/hw/ne2000-isa.c >> +++ b/hw/ne2000-isa.c >> @@ -61,24 +61,18 @@ static const VMStateDescription >> vmstate_isa_ne2000 = { >> } >> }; >> >> +#include "exec-memory.h" >> + > > > Should be at the top of the file. > Well, it was meant to stick out as a sore thumb, since it's incorrect except in memory.c and exec.c. I have it rendered in comic-sans in my editor for extra effect. I fixed it here and everywhere else. -- error compiling committee.c: too many arguments to function