From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qpzdt-0003Mc-F7 for qemu-devel@nongnu.org; Sun, 07 Aug 2011 05:27:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qpzds-0005UV-FC for qemu-devel@nongnu.org; Sun, 07 Aug 2011 05:27:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qpzds-0005UO-8M for qemu-devel@nongnu.org; Sun, 07 Aug 2011 05:27:32 -0400 Message-ID: <4E3E5A7E.3080709@redhat.com> Date: Sun, 07 Aug 2011 12:27:26 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-30-git-send-email-avi@redhat.com> <4E3C0CAE.6060801@codemonkey.ws> In-Reply-To: <4E3C0CAE.6060801@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 29/39] sun4u: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/05/2011 06:30 PM, Anthony Liguori wrote: >> - isa_bus_new(&s->qdev); >> + EbusState *s = container_of(pci_dev, EbusState, pci_dev); > > > DO_UPCAST() is the qdev macro for this. > Fixed. -- error compiling committee.c: too many arguments to function