From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qq5ej-0001RQ-RZ for qemu-devel@nongnu.org; Sun, 07 Aug 2011 11:52:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qq5ei-0008WL-R8 for qemu-devel@nongnu.org; Sun, 07 Aug 2011 11:52:49 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:45197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qq5ei-0008U4-Lw for qemu-devel@nongnu.org; Sun, 07 Aug 2011 11:52:48 -0400 Received: by gwb19 with SMTP id 19so1115907gwb.4 for ; Sun, 07 Aug 2011 08:52:47 -0700 (PDT) Message-ID: <4E3EB4CE.8030201@codemonkey.ws> Date: Sun, 07 Aug 2011 10:52:46 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1312723284-7549-1-git-send-email-hdegoede@redhat.com> <1312723284-7549-2-git-send-email-hdegoede@redhat.com> In-Reply-To: <1312723284-7549-2-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: Gerd Hoffmann , qemu-devel@nongnu.org On 08/07/2011 08:21 AM, Hans de Goede wrote: > To let the chardev now we're ready start receiving data. This is necessary > with the spicevmc chardev to get it registered with the spice-server. > > Signed-off-by: Hans de Goede > --- > usb-redir.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/usb-redir.c b/usb-redir.c > index e212993..ec88c0b 100644 > --- a/usb-redir.c > +++ b/usb-redir.c > @@ -809,6 +809,8 @@ static int usbredir_initfn(USBDevice *udev) > > qemu_chr_add_handlers(dev->cs, usbredir_chardev_can_read, > usbredir_chardev_read, usbredir_chardev_event, dev); > + /* Let the other side know we are ready */ > + qemu_chr_guest_open(dev->cs); You should do guest_open before adding handlers. Regards, Anthony Liguori > > return 0; > } > @@ -830,6 +832,7 @@ static void usbredir_handle_destroy(USBDevice *udev) > { > USBRedirDevice *dev = DO_UPCAST(USBRedirDevice, dev, udev); > > + qemu_chr_guest_close(dev->cs); > qemu_chr_close(dev->cs); > /* Note must be done after qemu_chr_close, as that causes a close event */ > qemu_bh_delete(dev->open_close_bh);