From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qq6QF-0003li-Eu
	for qemu-devel@nongnu.org; Sun, 07 Aug 2011 12:41:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qq6QE-0000W9-FO
	for qemu-devel@nongnu.org; Sun, 07 Aug 2011 12:41:55 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:56703)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qq6QE-0000W3-6j
	for qemu-devel@nongnu.org; Sun, 07 Aug 2011 12:41:54 -0400
Message-ID: <4E3EC04E.60606@mail.berlios.de>
Date: Sun, 07 Aug 2011 18:41:50 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1312663642-8298-1-git-send-email-weil@mail.berlios.de>
	<4E3EB457.6060202@codemonkey.ws>
In-Reply-To: <4E3EB457.6060202@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: Disable guest_agent for mingw32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Am 07.08.2011 17:50, schrieb Anthony Liguori:
> On 08/06/2011 03:47 PM, Stefan Weil wrote:
>> guest_agent is not supported for mingw32, so the default value
>> should be 'no', not 'yes'.
>
> Why is it not supported?  It should build just fine.
>
> If the answer is, -mms-bitfield, then we should fix slirp instead of 
> disabling guest-agent.
>
> Regards,
>
> Anthony Liguori

Code extract from configure:

   if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
       tools="qemu-nbd\$(EXESUF) $tools"
     if [ "$guest_agent" = "yes" ]; then
       tools="qemu-ga\$(EXESUF) $tools"
     fi
     if [ "$check_utests" = "yes" ]; then
       tools="check-qint check-qstring check-qdict check-qlist $tools"
       tools="check-qfloat check-qjson $tools"
     fi
   fi

MinGW32 is neither linux nor bsd nor solaris, so guest_agent="yes"
won't enable qemu-ga.exe.

Of course this (and the bitfield related problems) should be fixed in
git master, but not in stable-0.15. So for 0.15, the patch is a must
(unless you are prepared to take additional patches for the
bitfield issues).

Even for git master, the patch is reasonable because it allows
QEMU builds with most mingw32 installations. As soon as
there is a w32 QEMU working with glib-2.0 and a w32 qemu-ga.exe
(and some documentation in the QEMU wiki how to get glib-2.0
and python), the patch can be reverted.

Regards,
Stefan Weil