From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QqPCv-0007gE-MR
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:45:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QqPCu-00062V-L4
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:45:25 -0400
Received: from mail-pz0-f42.google.com ([209.85.210.42]:34233)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QqPCu-00062N-FB
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:45:24 -0400
Received: by pzk37 with SMTP id 37so2928226pzk.29
	for <qemu-devel@nongnu.org>; Mon, 08 Aug 2011 05:45:23 -0700 (PDT)
Message-ID: <4E3FDA5F.5050105@codemonkey.ws>
Date: Mon, 08 Aug 2011 07:45:19 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1312463195-13605-1-git-send-email-avi@redhat.com>	<1312463195-13605-2-git-send-email-avi@redhat.com>	<4E3BF599.4050207@codemonkey.ws>
	<20110808103606.GA10372@redhat.com>
In-Reply-To: <20110808103606.GA10372@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote:
>> Thinking more closely, I don't think this right.
>>
>> Updating on map ensured that the config was refreshed after each
>> time the bar was mapped.  In the very least, the config needs to be
>> refreshed during reset because the guest may write to the guest
>> space which should get cleared after reset.
>>
>> Regards,
>>
>> Anthony Liguori
>
> Not sure I understand. Which register, for example,
> do you have in mind?
> Could you clarify please?

Actually, you never need to call config_get() AFAICT.  It's called in 
every read/write access.  So I think the code you changed is extraneous now.

Regards,

Anthony Liguori

>
>>>   }
>>>
>>>   static int virtio_blk_init_pci(PCIDevice *pci_dev)
>