From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqPFe-0000KX-BD for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:48:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqPFd-0006f8-FR for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:48:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqPFd-0006et-8X for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:48:13 -0400 Message-ID: <4E3FDB08.606@redhat.com> Date: Mon, 08 Aug 2011 15:48:08 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-2-git-send-email-avi@redhat.com> <4E3BF599.4050207@codemonkey.ws> <20110808103606.GA10372@redhat.com> <4E3FDA5F.5050105@codemonkey.ws> In-Reply-To: <4E3FDA5F.5050105@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/08/2011 03:45 PM, Anthony Liguori wrote: > > Actually, you never need to call config_get() AFAICT. It's called in > every read/write access. So I think the code you changed is > extraneous now. Ok; I'll drop this patch and report (and just remove the code in virtio_map()). -- error compiling committee.c: too many arguments to function