From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqPd7-0007TU-H9 for qemu-devel@nongnu.org; Mon, 08 Aug 2011 09:12:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqPd6-0002wm-KG for qemu-devel@nongnu.org; Mon, 08 Aug 2011 09:12:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqPd6-0002wi-C6 for qemu-devel@nongnu.org; Mon, 08 Aug 2011 09:12:28 -0400 Message-ID: <4E3FE0B7.3090805@redhat.com> Date: Mon, 08 Aug 2011 16:12:23 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312808190-31074-1-git-send-email-avi@redhat.com> <4E3FDDD6.9070501@codemonkey.ws> In-Reply-To: <4E3FDDD6.9070501@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/08/2011 04:00 PM, Anthony Liguori wrote: > On 08/08/2011 07:56 AM, Avi Kivity wrote: >> QEMU deals with a lot of fixed width integer types; their names >> (uint64_t etc) are clumsy to use and take up a lot of space. >> >> Following Linux, introduce shorter names, for example U64 for >> uint64_t. > > Except Linux uses lower case letters. > > I personally think Linux style is wrong here. The int8_t types are > standard types. > > Besides, we save lots of characters by using 4-space tabs instead of > 8-space tabs. We can afford to spend some of those saved characters > on using proper type names :-) > It's not about saving space, it's about improving readability. We have about 21k uses of these types, they deserve short names. -- error compiling committee.c: too many arguments to function