From: Avi Kivity <avi@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: blauwirbel@gmail.com, Jan Kiszka <jan.kiszka@siemens.com>,
aliguori@us.ibm.com, amit.shah@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type
Date: Mon, 08 Aug 2011 16:40:17 +0300 [thread overview]
Message-ID: <4E3FE741.7060302@redhat.com> (raw)
In-Reply-To: <20110808102858.54ab1b55@doriath>
On 08/08/2011 04:28 PM, Luiz Capitulino wrote:
> On Mon, 08 Aug 2011 16:27:05 +0300
> Avi Kivity<avi@redhat.com> wrote:
>
> > On 08/08/2011 04:25 PM, Luiz Capitulino wrote:
> > > >
> > > > I'm worried about the following race:
> > > >
> > > > stop
> > > > (qemu stopped for internal reason)
> > > > stop comment processed
> > > >
> > > > resume
> > > >
> > > > The (qemu stopped for internal reason) part is lost.
> > >
> > > If the "stop" you're referring to happens through vm_stop(), then no,
> > > it won't be lost because do_vm_stop() doesn't allow qemu to be stopped
> > > twice.
> >
> > What happens then? The user sees an error?
>
> It's ignored.
Well, then, the user won't know something happened and will happily
resume the guest, like I outlined above.
When you ignore something in the first set, something breaks in the third.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-08-08 13:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 15:17 [Qemu-devel] [PATCH 0/7]: Introduce the QemuState type Luiz Capitulino
2011-08-03 15:17 ` [Qemu-devel] [PATCH 1/7] Move vm_state_notify() prototype from cpus.h to sysemu.h Luiz Capitulino
2011-08-03 15:17 ` [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type Luiz Capitulino
2011-08-04 9:55 ` Avi Kivity
2011-08-04 10:17 ` Jan Kiszka
2011-08-04 10:27 ` Jan Kiszka
2011-08-04 14:06 ` Luiz Capitulino
2011-08-08 11:22 ` Avi Kivity
2011-08-08 13:25 ` Luiz Capitulino
2011-08-08 13:27 ` Avi Kivity
2011-08-08 13:28 ` Luiz Capitulino
2011-08-08 13:40 ` Avi Kivity [this message]
2011-08-08 13:47 ` Luiz Capitulino
2011-08-08 13:54 ` Avi Kivity
2011-08-08 14:06 ` Luiz Capitulino
2011-08-08 14:27 ` Avi Kivity
2011-08-08 20:25 ` Luiz Capitulino
2011-08-03 15:17 ` [Qemu-devel] [PATCH 3/7] QemuState: Add additional states Luiz Capitulino
2011-08-04 9:02 ` Markus Armbruster
2011-08-04 12:32 ` Kevin Wolf
2011-08-04 13:23 ` Anthony Liguori
2011-08-04 13:54 ` Luiz Capitulino
2011-08-08 6:02 ` Markus Armbruster
2011-08-03 15:17 ` [Qemu-devel] [PATCH 4/7] Drop the incoming_expected global variable Luiz Capitulino
2011-08-03 15:17 ` [Qemu-devel] [PATCH 5/7] Drop the vm_running " Luiz Capitulino
2011-08-03 15:17 ` [Qemu-devel] [PATCH 6/7] Monitor: Don't allow cont on bad VM state Luiz Capitulino
2011-08-03 15:32 ` Jan Kiszka
2011-08-03 17:32 ` Luiz Capitulino
2011-08-04 8:42 ` Jan Kiszka
2011-08-03 15:17 ` [Qemu-devel] [PATCH 7/7] QMP: query-status: Introduce 'status' key Luiz Capitulino
2011-08-04 9:06 ` [Qemu-devel] [PATCH 0/7]: Introduce the QemuState type Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3FE741.7060302@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).