From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqQ4A-00036J-29 for qemu-devel@nongnu.org; Mon, 08 Aug 2011 09:40:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqQ48-0008Ed-VA for qemu-devel@nongnu.org; Mon, 08 Aug 2011 09:40:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqQ48-0008EZ-Mx for qemu-devel@nongnu.org; Mon, 08 Aug 2011 09:40:24 -0400 Message-ID: <4E3FE741.7060302@redhat.com> Date: Mon, 08 Aug 2011 16:40:17 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312384643-581-1-git-send-email-lcapitulino@redhat.com> <1312384643-581-3-git-send-email-lcapitulino@redhat.com> <4E3A6C8C.8060304@redhat.com> <4E3A71D3.6030700@siemens.com> <4E3FC6E6.1050202@redhat.com> <20110808102510.6d315297@doriath> <4E3FE429.4010509@redhat.com> <20110808102858.54ab1b55@doriath> In-Reply-To: <20110808102858.54ab1b55@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: blauwirbel@gmail.com, Jan Kiszka , aliguori@us.ibm.com, amit.shah@redhat.com, qemu-devel@nongnu.org On 08/08/2011 04:28 PM, Luiz Capitulino wrote: > On Mon, 08 Aug 2011 16:27:05 +0300 > Avi Kivity wrote: > > > On 08/08/2011 04:25 PM, Luiz Capitulino wrote: > > > > > > > > I'm worried about the following race: > > > > > > > > stop > > > > (qemu stopped for internal reason) > > > > stop comment processed > > > > > > > > resume > > > > > > > > The (qemu stopped for internal reason) part is lost. > > > > > > If the "stop" you're referring to happens through vm_stop(), then no, > > > it won't be lost because do_vm_stop() doesn't allow qemu to be stopped > > > twice. > > > > What happens then? The user sees an error? > > It's ignored. Well, then, the user won't know something happened and will happily resume the guest, like I outlined above. When you ignore something in the first set, something breaks in the third. -- error compiling committee.c: too many arguments to function