From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqQbc-000342-PS for qemu-devel@nongnu.org; Mon, 08 Aug 2011 10:15:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqQbb-0006Un-SG for qemu-devel@nongnu.org; Mon, 08 Aug 2011 10:15:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqQbb-0006Ue-GD for qemu-devel@nongnu.org; Mon, 08 Aug 2011 10:14:59 -0400 Message-ID: <4E3FF013.5010906@redhat.com> Date: Mon, 08 Aug 2011 16:17:55 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1312808190-31074-1-git-send-email-avi@redhat.com> <4E3FDDD6.9070501@codemonkey.ws> In-Reply-To: <4E3FDDD6.9070501@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org Am 08.08.2011 15:00, schrieb Anthony Liguori: > On 08/08/2011 07:56 AM, Avi Kivity wrote: >> QEMU deals with a lot of fixed width integer types; their names >> (uint64_t etc) are clumsy to use and take up a lot of space. >> >> Following Linux, introduce shorter names, for example U64 for >> uint64_t. > > Except Linux uses lower case letters. > > I personally think Linux style is wrong here. The int8_t types are > standard types. I fully agree, we should use the standard types. > Besides, we save lots of characters by using 4-space tabs instead of > 8-space tabs. We can afford to spend some of those saved characters on > using proper type names :-) Heh, I like this reasoning. :-) Kevin