From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QqVKg-0002Bj-KM
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 15:17:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QqVKd-0006yv-N9
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 15:17:50 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:46808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QqVKd-0006xt-Ki
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 15:17:47 -0400
Received: by gyd12 with SMTP id 12so2424033gyd.4
	for <qemu-devel@nongnu.org>; Mon, 08 Aug 2011 12:17:41 -0700 (PDT)
Message-ID: <4E403652.8000306@codemonkey.ws>
Date: Mon, 08 Aug 2011 14:17:38 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1312663642-8298-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1312663642-8298-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: Disable guest_agent for mingw32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org

On 08/06/2011 03:47 PM, Stefan Weil wrote:
> guest_agent is not supported for mingw32, so the default value
> should be 'no', not 'yes'.
>
> This removes the dependencies to glib-2.0 and python which
> makes native and cross builds for w32 much easier (no need
> to get and install these extra packages).
>
> It also avoids the problems caused by different bitfield alignment
> which is required by glib-2.0.
>
> It is still possible to set guest_agent=yes via configure option.
>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>

This came in too late to make 0.15.0.  I'd consider applying this to the 
stable branch but I'd really prefer we fix the slirp packing issue directly.

Regards,

Anthony Liguori

> ---
>   configure |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 0c67a4a..4cb33d9 100755
> --- a/configure
> +++ b/configure
> @@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then
>     bindir="\${prefix}"
>     sysconfdir="\${prefix}"
>     confsuffix=""
> +  guest_agent="no"
>   fi
>
>   werror=""