From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqVdy-0003jN-Kx for qemu-devel@nongnu.org; Mon, 08 Aug 2011 15:37:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqVdx-0002eX-DS for qemu-devel@nongnu.org; Mon, 08 Aug 2011 15:37:46 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:49576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqVdx-0002eT-7x for qemu-devel@nongnu.org; Mon, 08 Aug 2011 15:37:45 -0400 Received: by pzk37 with SMTP id 37so3558431pzk.29 for ; Mon, 08 Aug 2011 12:37:44 -0700 (PDT) Message-ID: <4E403AF6.6090301@codemonkey.ws> Date: Mon, 08 Aug 2011 14:37:26 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1312285630-15507-1-git-send-email-pbonzini@redhat.com> <1312285630-15507-2-git-send-email-pbonzini@redhat.com> <4E3C12BD.1090105@codemonkey.ws> <4E3D5AFF.3010605@redhat.com> In-Reply-To: <4E3D5AFF.3010605@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/2] ptimer: move declarations to ptimer.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 08/06/2011 10:17 AM, Paolo Bonzini wrote: > On 08/05/2011 05:56 PM, Anthony Liguori wrote: >> On 08/02/2011 06:47 AM, Paolo Bonzini wrote: >>> Since the next patch will move VMState declarations for ptimers out >>> of hw/hw.h, prepare a place for them. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> hw/arm_timer.c | 1 + >>> hw/etraxfs_timer.c | 1 + >>> hw/grlib_apbuart.c | 1 + >>> hw/grlib_gptimer.c | 1 + >>> hw/lan9118.c | 1 + >>> hw/leon3.c | 1 + >>> hw/lm32_timer.c | 1 + >>> hw/mcf5206.c | 1 + >>> hw/mcf5208.c | 1 + >>> hw/milkymist-sysctl.c | 1 + >>> hw/musicpal.c | 1 + >>> hw/ptimer.c | 1 + >>> hw/ptimer.h | 27 +++++++++++++++++++++++++++ >>> hw/sh_timer.c | 1 + >>> hw/slavio_timer.c | 1 + >> >> With this series applied, I get: >> >> In file included from /home/anthony/git/qemu/hw/slavio_timer.c:27:0: >> /home/anthony/git/qemu/hw/ptimer.h:27:33: error: expected ‘=’, ‘,’, ‘;’, >> ‘asm’ or ‘__attribute__’ before ‘vmstate_ptimer’ >> /home/anthony/git/qemu/hw/slavio_timer.c:338:9: error: ‘vmstate_ptimer’ >> undeclared here (not in a function) >> make[1]: *** [slavio_timer.o] Error 1 >> make: *** [subdir-sparc-softmmu] Error 2 > > Never attribute to chance what can be attributed to stupidity. Forgot I > had configured with --target-list. It happens :-) Regards, Anthony Liguori > > Paolo > >