From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36634)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Qqn1f-0000Wg-SL
	for qemu-devel@nongnu.org; Tue, 09 Aug 2011 10:11:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Qqn1b-0007SE-2z
	for qemu-devel@nongnu.org; Tue, 09 Aug 2011 10:11:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8655)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Qqn1a-0007QZ-Ra
	for qemu-devel@nongnu.org; Tue, 09 Aug 2011 10:11:19 -0400
Message-ID: <4E4123A0.3070408@redhat.com>
Date: Tue, 09 Aug 2011 14:10:08 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1311179069-27882-1-git-send-email-armbru@redhat.com>
	<1311179069-27882-45-git-send-email-armbru@redhat.com>
	<CAOq732+ry+aHqcP0GgyWkwN_w6c5=49Cp75Y5r37ndKwfWaz_w@mail.gmail.com>
	<m339hlb9ap.fsf@blackfin.pond.sub.org>
	<CAFEAcA-0BZL2ND0ipLVSOYjNUAXZ9fTNOEJhD9JtAjpXoYYaug@mail.gmail.com>
	<m3oc06kj6i.fsf@blackfin.pond.sub.org>
	<CAOq732+0rp73uZoeU0k9TkR5KQgy-fZGtfVn0hGdH=HLkvbQNg@mail.gmail.com>
	<m362me7hft.fsf@blackfin.pond.sub.org>
	<CAOq732Ko0m5PqcSud_yisX2LpkyT_f_QqbuNHqDo_U7qj6iZXA@mail.gmail.com>
	<m3pqkm5u20.fsf@blackfin.pond.sub.org>
	<CAOq732Lob-idMtNsr1FQLwOMnS3bn+hGq3PikmAXOO8jiwk+mA@mail.gmail.com>
	<m3hb5ywdz0.fsf@blackfin.pond.sub.org>
	<CAOq732JG+i+oCtgKrjS+ikVv-M6um3Z0_OuXeyNDx69PGdw9ig@mail.gmail.com>
	<4E3A5221.3030407@redhat.com>
	<CAOq732Kk7xVtZ_xRzqmm9bZh_SbicZV-2esubaEMiJkRsgCsBg@mail.gmail.com>
	<4E40E2A0.9050405@redhat.com>
	<m339hadcir.fsf@blackfin.pond.sub.org>
In-Reply-To: <m339hadcir.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is
 suitable for microdrive" test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, quintela@redhat.com, dbaryshkov@gmail.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com

Am 09.08.2011 13:56, schrieb Markus Armbruster:
> bdrv_is_locked() is about the frontend's media lock.  To make this more
> obvious, my PATCH 29/55 replaces it by bdrv_dev_is_medium_locked().  It
> does *not* query the backend's lock (which may not even exist!) set by
> bdrv_set_locked().

This sounds wrong (the behaviour, not your analysis). Do you plan to
remove bdrv_dev_is_medium_locked() as well? It is used by IDE and
scsi-disk (easy to replace) and in eject_device() in blockdev.c. Maybe
the 'eject' monitor command should be handled by another callback into
the device.

Kevin